Repository navigation
feat(changelog): Include labelled PRs from outside a workspace - #980
Merged
Merged
Conversation
A workspace changelog only lists commits that touch the workspace's files. A package generated from something outside it, such as @sentry/api from Sentry's API spec, then gets releases whose notes say "No documented changes": the backend commits that changed the spec are filtered out. changelog.includeLabels lists PR labels that put a commit in the workspace's changelog wherever its files are. Workspace placeholders expand in it, so a glob key can give each package its own label. With the setting, commits outside the workspace are looked up on GitHub too, so their labels can be read. Co-Authored-By: BYK <126780+BYK@users.noreply.github.com>
Contributor
|
BYK
approved these changes
Nov 18, 2026
8 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A workspace changelog only lists commits that touch the workspace's files. That breaks for a package generated from something outside it. getsentry/sentry's
@sentry/apiis built from the API spec, which any backend change can alter, and its automatic spec releases (api@2.9.0throughapi@2.13.0) say "No documented changes" because the commits that changed the spec are filtered out.changelog.includeLabelslists PR labels that put a commit in the workspace's changelog wherever its files are. Workspace placeholders expand in it, so a glob key can give each package its own label:The same rule applies to the PR preview. Like
includePathsandunownedPaths, it's only allowed with release workspaces. With it set, Craft also looks up the PRs of commits outside the workspace so it can read their labels, which means more GitHub lookups. Without it, behavior is unchanged.via @BYK.
--
View Session [Sentry]